Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment on CLA assistant #46

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Add comment on CLA assistant #46

merged 1 commit into from
Jan 29, 2019

Conversation

StephanSiemen
Copy link
Contributor

No description provided.

@FussyDuck
Copy link

FussyDuck commented Jan 5, 2019

CLA assistant check
All committers have signed the CLA.

@StephanSiemen
Copy link
Contributor Author

@alexamici, we should ensure that in future every contribution accepts the CLA! with this pull request the setup is done and active.

@coveralls
Copy link

coveralls commented Jan 5, 2019

Pull Request Test Coverage Report for Build 107

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.9%) to 75.93%

Files with Coverage Reduction New Missed Lines %
cfgrib/messages.py 2 99.38%
Totals Coverage Status
Change from base Build 105: -19.9%
Covered Lines: 842
Relevant Lines: 1073

💛 - Coveralls

@alexamici
Copy link
Contributor

alexamici commented Jan 5, 2019

@StephanSiemen that's great!

Please note that the failures in Travis are unrelated to the PR (they are due to a bug in xarray==0.11.1, see #44!), and I'm not able to merge the PR because the continuous-integration checks are now required.

I don't have admin permission on the repo myself, and I assume you changed the repo settings. I'd suggest you to revert to not requiring continuous-integration to pass, as there are many reasons a maintainer may want to merge a failing PR. The license/cla must probably stay required.

@alexamici
Copy link
Contributor

@StephanSiemen note also that from my home connection the URL http://claassistant.ecmwf.int:5000/ecmwf/cfgrib?pullRequest=46 times out and nmap classifies the port as filtered.

@alexamici alexamici merged commit 579fc6c into master Jan 29, 2019
@alexamici alexamici deleted the StephanSiemen-CLA-note branch February 3, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants