Offloading discontiguous host data #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sbrdar
commented
Dec 4, 2024
sbrdar
commented
- offloading discontiguous data via WrappedDataStorage
- Field can wrap discontiguous array and copy it to a contiguous memory on the device
wdeconinck
reviewed
Dec 9, 2024
wdeconinck
reviewed
Dec 9, 2024
wdeconinck
reviewed
Dec 9, 2024
| do l=1,5 | ||
| fview(i,j,l) = 1000*i+100*j+10*1+l | ||
| enddo | ||
| !$acc parallel loop deviceptr(fview) |
There was a problem hiding this comment.
I'm afraid that this deviceptr(fview) with fview having the POINTER attribute is non-standard OpenACC and will not compile with Cray compiler. We need to create a separate subroutine just for kernels with deviceptr 😞, where the deviceptr is passed as argument without POINTER attribute.
There was a problem hiding this comment.
This was missing. Thank you for pointing it out. I have added kernel subroutines to call ACC pragmas. See 5dc24af.
wdeconinck
reviewed
Dec 9, 2024
wdeconinck
reviewed
Dec 9, 2024
wdeconinck
requested changes
Dec 9, 2024
…dDataSore::contiguous_
…ll with dummy call -> Fortran standard for ACC
|
@wdeconinck Thank you for the comments! |
wdeconinck
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.