Fixed ordering of fixup_halos and halo_exhange.execute_adjoint in StructuredColumns.cc
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odlomax
changed the title
fixup_halos and halo_exhange in StructuredColumns.ccfixup_halos and halo_exhange.execute_adjoint in StructuredColumns.cc
|
@wdeconinck Am I correct in thinking the test failure isn't related to these commits? Let me know if there's anything I can do. |
|
I would like to see what @MarekWlasak has to say about this, otherwise it is good to merge for me. |
|
@MarekWlasak, please could you bless or condemn this PR! |
|
@wdeconinck - This PR is blessed! |
wdeconinck
added a commit
that referenced
this pull request
Nov 18, 2024
* release/0.40.0: (40 commits) Update changelog Version 0.40.0 Add hicLaunchHostFunc for async host functions Add test for various use cases of StructuredInterpolation2D with limiter Implement StructureInterpolation2D for 3-dimensional fields with extra variables) Fix application of limiter for StructuredInterpolation2D Protect atlas_test_array_view_variant to eckit v 1.27.0 Move example-fortran inside atlas_HAVE_DOCS (#235) Fix possible device-memory leak in WrappedDataStore (fixes #234) add device data on FieldSet Add test for fieldset device operators Add fieldset device operators Update fctest_field_gpu to test acc deviceptr Update test_field_acc to test acc deviceptr Add device_data Fortran access to Field Refactored spherical vector interpolation method. (#227) Refactored (un)pack_vector_fields. (#226) Integrate `pack_vector_fields` into `SphericalVector` Interpolation method. (#224) Fixed ordering of fixup_halos and halo_exhange in StructuredColumns.cc (#223) Tidied headers and error message. (#231) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst integrating
util::pack_vector_fieldsinto theSphericalVectorinterpolation method, I uncovered a bug inStructuredColumns. The methodsfixup_halosandhalo_exchange.execute_adjointwere called in the wrong order during a halo exchange adjoint. This PR fixes the bug.I'd initially missed this by adding (and then forgetting) a workaround in the
SphericalVectortest.@MarekWlasak this will likely be of interest to you.