add Fortran API for functionspace::CellColumns #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #164 +/- ##
===========================================
- Coverage 79.40% 79.12% -0.29%
===========================================
Files 822 831 +9
Lines 62223 62688 +465
===========================================
+ Hits 49410 49599 +189
- Misses 12813 13089 +276 ☔ View full report in Codecov by Sentry. |
wdeconinck
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Thanks @sbrdar this was missing indeed!
A few cosmetic remarks to address.
| std::strncpy(checksum, checksum_str.c_str(), size + 1); | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
Please delete commented code.
Comment on lines
10
to
12
| #:include "internals/atlas_generics.fypp" | ||
|
|
||
| #:set ranks = [0,1] |
There was a problem hiding this comment.
Please remove, and also rename file with ".F90" extension. No fypp is used here.
wdeconinck
added a commit
that referenced
this pull request
Dec 11, 2023
* release/0.36.0: (25 commits) Update Changelog Version 0.36.0 Add atlas_Redistribution to atlas_module Performance improvement in EqualAreaPartitioner for StructuredGrid Add EqualAreaPartitioner which is geometry based compared to EqualRegionsPartitioner which is loadbalanced Add fallback mechanism to MatchingMeshPartitionerLonLatPolygon Fix MatchingMeshPartitionerBruteForce Fix MDPI_gulfstream: 180 degrees phase shift corrected Feature/fortran api init functions (#165) Fix failing tests for IntelLLVM Release builds GHA: Install intel-oneapi with mpi-devel for access to MPI headers and Fortran modules Fix intel compiler version in github actions, and add IntelLLVM Add compile flag -fno-finite-math-only for Intel LLVM compiler (icx, icpx) Add Fortran API for functionspace::CellColumns (#164) Cleanup Fix logic Fix interpolation warnings Add Fortran interface for Redistribution (#160) Add atlas_TriangularMeshBuilder with Fortran interface for serial meshes Reduce header dependency on atlas_io to prepare for eckit_codec adaptor library ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.