Fix fastapi request #171
Merged
Fix fastapi request #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale of the changes to the
environment.yml:starlette-exportercan be installed from condauvicorn > 0.25.0makes the application unreachable (all endpoints return a404)fastapi > 0.108.0(or relatedstarlettedependency upgrade) unexpectedly changes the behaviour offastapi.Request.url, causing the links to e.g.self,nextandprevnot to be built properly (missing/api/retrieve/v1in tue URLs) -> since this logic is inogc-api-processes-fastapipackage, this should probably be moved thereUPDATE 24-01-2024
As per points 2. and 3., issues are solved also if BOTH
fastapianduvicornare at their (current) latest versions (see encode/uvicorn#2213 and fastapi/fastapi#10978)->
environment.ymlis changed accordingly