This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Fix missing licences test #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmans2
approved these changes
Jul 25, 2024
malmans2
reviewed
Jul 25, 2024
| @@ -49,30 +49,29 @@ def test_validate_constraints(api_root_url: str) -> None: | |||
|
|
|||
|
|
|||
| def test_collection_missing_licence( | |||
| api_root_url: str, api_key_anon: str, request_year: str | |||
| api_root_url: str, api_key_test: str, request_year: str | |||
There was a problem hiding this comment.
Suggested change
| api_root_url: str, api_key_test: str, request_year: str | |
| api_root_url: str, api_key_anon: str, request_year: str |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, initially motivated by a fix required to the
test_collection_missing_licencetest due to development in ecmwf-projects/cads-processing-api-service#194, implements the following:conftest.pyso that the test user api key is not written in the code, but is instead taken from aCADS_TEST_KEYenv variable (@Trik16 to be added to the secrets). If the env variable is not defined, all (now few) tests relying on it are skipped;messagefield in the response to the process submission request by the Anonymous user.Needs