Bundle integration for Atlas #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuterbal
force-pushed
the
nabr_nab_atlas_structures
branch
from
8a73dbe to
5960989
Compare
wdeconinck
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the review of #54, this adds Atlas and its dependencies as optional projects to the bundle.
By default, they are not being built, which should allow to pick up an existing Atlas installation as usual.
--with-atlaswill enable buildingeckit,fckitandatlas. By default, tests are disabled for these dependencies but can be enabled using--with-dependency-tests.I have also enabled Github actions integration for the new variant.