Improve documentation for TaskAPI
#8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koegel
requested changes
Oct 2, 2020
| * @param provider the {@link TaskProvider} that should be registered | ||
| * | ||
| * @returns a `Disposable` that can be invoked to unregister the given resolver | ||
| */wit |
| registerRunner(runners: TaskRunnerRegistry): void; | ||
| } | ||
|
|
||
| export const TaskRunner = Symbol('TaskRunner'); | ||
| /** A Task Runner knows how to run and kill a Task of a particular type. */ | ||
| /** | ||
| * A {@link TaskRunner} knows how to run and kill a task of a particular type. |
There was a problem hiding this comment.
It does not know how to kill a task imho.
|
Thanks for the fast review. I addressed the issues and squashed the changes into a single commit |
koegel
requested changes
Oct 5, 2020
| registerRunner(runners: TaskRunnerRegistry): void; | ||
| } | ||
|
|
||
| export const TaskRunner = Symbol('TaskRunner'); | ||
| /** A Task Runner knows how to run and kill a Task of a particular type. */ | ||
| /** | ||
| * A {@link TaskRunner} knows how to run and kill a task of a particular type. |
koegel
approved these changes
Oct 5, 2020
tortmayr
force-pushed
the
task
branch
6 times, most recently
from
979bacd to
960cedd
Compare
Fixes eclipse-theia#8694 Signed-off-by: Tobias Ortmayr <[email protected]> Contributed on behalf of STMicroelectronics
|
Merged upstream with eclipse-theia#8695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Ortmayr [email protected]
Contributed on behalf of STMicroelectronics