Add Comment#timestamp #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a note, the 4 first commits are commits on theia/master not yet available on eclipsesource/master. Only 2df36ae is relevant |
rschnekenbu
force-pushed
the
issues/11702
branch
from
2df36ae
to
65bd265
Compare
lucas-koehler
requested changes
Dec 13, 2022
| if (timeStamp === undefined) { | ||
| return ''; | ||
| } | ||
| return timeStamp.toLocaleDateString(); |
There was a problem hiding this comment.
When I test this rebased onto v1.27.0, timestamp was already a string here. Thus, this method did not exist and an exception was thrown.
From the console:
comments-contribution.ts:114 Uncaught (in promise) TypeError: timeStamp.toLocaleDateString is not a function
at ReviewComment.timeStamp (comment-thread-widget.tsx:504:26)
at ReviewComment.render (comment-thread-widget.tsx:480:58)
at finishClassComponent (react-dom.development.js:17160:1)
at updateClassComponent (react-dom.development.js:17110:1)
at beginWork (react-dom.development.js:18620:1)
at HTMLUnknownElement.callCallback (react-dom.development.js:188:1)
at Object.invokeGuardedCallbackDev (react-dom.development.js:237:1)
at invokeGuardedCallback (react-dom.development.js:292:1)
at beginWork$1 (react-dom.development.js:23203:1)
at performUnitOfWork (react-dom.development.js:22157:1)
|
New 'basic' version of timestamp support using a string rather than a date. |
rschnekenbu
force-pushed
the
issues/11702
branch
from
cfe4978
to
e29c860
Compare
|
Thanks for your review, @lucas-koehler. I tested again the branch on 1.27.0, the timestamp is still displayed with your last suggestions. |
lucas-koehler
approved these changes
Dec 19, 2022
rschnekenbu
force-pushed
the
issues/11702
branch
2 times, most recently
from
376dbca
to
5d615cd
Compare
Contributed on behalf of STMicroelectronics Fixes eclipse-theia#11702
rschnekenbu
force-pushed
the
issues/11702
branch
from
5d615cd
to
6895086
Compare
|
close PR as the one on main fork has been merged (eclipse-theia#12007) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add Comment#timestamp optional property
This adds the timeStamp optional property from Comment to improve vscode api coverage. It also displays the timestamp of each comments in the Comment Thread widget
Fixes eclipse-theia#11702
Contributed on behalf of ST Microelectronics
How to test
Note: there are currently some issues with menus, since theia 1.28.0. This is due to eclipse-theia#11290, integrated in 1.28.0. Prior to this change, the comment sample works on theia 1.27.0. So to test this change, I cherry-picked my commit on top of 1.27.0 tag. Please see also eclipse-theia#11730 for this menu issues.
Install forked extension #comment-sample-0.0.1 vsix file
Create a comment using the side bar while comparing 2 test files.
The timestamp should be displayed along the user name.
Review checklist
Reminder for reviewers