Transpile Theia to ES6 #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
reviewed
Apr 29, 2021
packages/plugin-ext/src/main/browser/plugin-contribution-handler.ts
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
sgraband
force-pushed
the
es6-migration
branch
4 times, most recently
from
c79a1f6 to
e2bf52d
Compare
sgraband
force-pushed
the
es6-migration
branch
3 times, most recently
from
bede031 to
286ee01
Compare
sgraband
force-pushed
the
es6-migration
branch
6 times, most recently
from
5e5f6e1 to
f7b2b4c
Compare
sgraband
force-pushed
the
es6-migration
branch
2 times, most recently
from
e6f4f4a to
105146d
Compare
sgraband
force-pushed
the
es6-migration
branch
5 times, most recently
from
4d283b8 to
d036518
Compare
Signed-off-by: Esther Perelman <[email protected]>
The CLI parsing logic is broken in `@theia/cli`. The help doesn't show the right information. The issue comes from using `yargs` at the script level in some places, leading to corrupt global `yargs` state. This commit refactors code around so that `--help` works as expected. `theia start --help` now display's the target application's CLI help rather than `theia`'s help.
The commit updates the following dependencies: - `@electron/get`: updates the outdated `electron-download` dependency to the newer `@electron/get` dependency, and adjust the code to perform the `ffmpeg` replacement. - `css-loader`: updated to newest version which supports webpack 5, and includes security updates. Signed-off-by: vince-fugnitto <[email protected]>
sgraband
force-pushed
the
es6-migration
branch
from
d036518 to
3cafe5a
Compare
…in-api-rpc-model.ts Signed-off-by: Petro Dzyuba <[email protected]>
The commit updates `menus` to not fail the layout when there are no commands attached to them, and instead log the error. Previously, if a command was unregistered and a command referenced it the layout would fail, and possibly also fail to start the application. The change also includes: - a bogus menu registration in `api-samples` to verify the feature in the future. - an api test to verify that registration does not fail for menus with invalid commands. Signed-off-by: vince-fugnitto <[email protected]>
…ia#9727) Refactor to hide VS Code interfaces behind core services Signed-off-by: Thomas Mäder <[email protected]>
The commit fixes the `quick-command` behavior which would not display the list of recently used commands properly when users would use the `quick-command` + type the prefix value, instead of triggering the command directly. The change refactors the code to perform the `reset` when we trigger the picks so we pick up the latest commands available. Signed-off-by: vince-fugnitto <[email protected]>
Due to incorrect `scm` tree view after executing file actions (like `stage`/`unstage`), Added `onDidChangeResources` listener to the `scm` provider which recreates `scm` tree on every resource change. Signed-off-by: Esther Perelman <[email protected]>
Fixes: eclipse-theia#9927 The commit fixes a broken link in the `@theia/keymaps` readme. The fix includes updating the link to point to our documentation site which is not subject to change as frequently as referencing code directly. Signed-off-by: Jonas Helming <[email protected]>
The commit refactors the binding of preference schemas so they can be easily rebinding by downstream extenders and applications if necessary. Signed-off-by: vince-fugnitto <[email protected]>
The commit updates the `file-search` api-tests (integration) by testing the following: - verify `fileAndRange` property by default, and once a search is performed. - verify that `splitFilterAndRange` successfully handles different input value combinations.
The commit updates the font-family for both the input and result label in the `find-widget` (embedded file-search) in the monaco editor. The change updates the font-family like the rest of the application for consistency (and aligns with vscode) rather than using the default monospaced font. Signed-off-by: vince-fugnitto <[email protected]>
The commit updates the styling of the `quick-input` to restore the drop-shadow which was previously present (and present in vscode) following the monaco upgrade. Signed-off-by: vince-fugnitto <[email protected]>
Signed-off-by: Rohan Sharma <[email protected]>
The commit includes updates to both `filterItems` and `findMatches` in order to make them both `fuzzy` supported. The method `filterItems` which is used to filter a list of quick-pick-items based on a filter is now responsible for filtering items based on `fuzzy` by an item's `label`, `description` or `detail` (previously only substring `label` matches). The method will now also properly reset highlights on subsequent filtering, and will apply the proper highlighting based on which item property it matched against. The method `findMatches` was also updated in order to support fuzzy, and it will now properly compute highlights and no longer compute them only if they are substring matches. The commit also includes test-cases to verify the behavior of both methods under different conditions and edge-cases. Signed-off-by: vince-fugnitto <[email protected]>
Using Node's builtin require function to dynamically import scripts makes bundling Node apps difficult when using tools like Webpack. Add a new package `@theia/dynamic-require`: This is a minimal package that re-export a function wrapping Node's require. The purpose of this is to factorize dynamic requires into a single package to make bundling easier. Remove as many occurences of Node require and replace the few required ones with `@theia/dynamic-require`. Add a new eslint rule `import/no-dynamic-require` to help detect places that would benefit from `@theia/dynamic-require`.
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Colin Grant <[email protected]>
Refactor the code to upload files via HTTP rather than WS. This simplifies the code by removing the ad-hoc WS upload protocol and should make it easier to configure proxies as it will be using good ol' HTTP. Note 1: The file upload is done over HTTP POST `multipart/form-data`. Note 2: I had to use the older XMLHttpRequest (XHR/AJAX) API in order to monitor the upload progress. The Fetch API is not there yet. Add new preference `files.maxConcurrentUploads` that defaults to 1 as it seems to the be fastest on my test environment. Can be user-customized. Use `async-mutex` semaphores in order to throttle uploads. `p-queue` doesn't work in the browser.
The commit fixes the paths which are displayed during the `quick-file-search`: - direct child resources of a root should not have a description - fixes root-name for multi-root workspaces - fixes label for multi-root workspaces when they are direct child resources of the given root. Signed-off-by: vince-fugnitto <[email protected]>
Transpiles theia to ES2017. To keep support of es5 based vscode extensions, the @es5ClassCompat tag was used. The tag was also applied to be used with theia es5 plugins. Contributed on behalf of STMicroelectronics Signed-off-by: Simon Graband <[email protected]> Co-authored-by: Paul Maréchal <[email protected]>
sgraband
force-pushed
the
es6-migration
branch
from
3cafe5a to
552df8f
Compare
|
Merged upstream with eclipse-theia#9436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is is a work-in-progress PR for transpiling Theia to es6. To continue supporting es5 based VSCode extensions, the
@es5ClassCompattag was used.The tag was also applied to be used with Theia es5 plugins. This is however yet to be tested.
We would like to gather feedback while tackling the remaining issues, so feel free to comment on this PR!
Open issues:
@es5ClassCompattag is not working for all of the classes intypes-impl.tsThe tag is failing on
LocationandDiagnosticRelatedInformationbecause of anCannot access Location before its initializationerrorApplying the tag to
CodeLens,TreeItem,ProgressExecution,ShellExecutionandDebugAdapterExecutablewill result in aCan't resolve @theia/plugin ERROR.phosphorjsandinversifyjs, however we could not find any regressions while testing. This may need some further research.Contributed on behalf of STMicroelectronics
Signed-off-by: Simon Graband [email protected]
How to test
To test the support for es5 VSCode extensions, you can try out one of the extensions described here: microsoft/vscode#68698.
Review checklist
Reminder for reviewers