Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonFormsStyleContext description to Styles.md file #1665

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Add JsonFormsStyleContext description to Styles.md file #1665

merged 3 commits into from
Dec 17, 2020

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Dec 9, 2020

Add JsonFormsStyleContext description to Styles.md file

Closes #1660

@coveralls
Copy link

coveralls commented Dec 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 88.488% when pulling 941d74d on TheZoker:add-styles-context into cd457e1 on eclipsesource:master.

sdirix
sdirix requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes.

packages/vanilla/README.md Outdated Show resolved Hide resolved
packages/vanilla/Styles.md Outdated Show resolved Hide resolved
packages/vanilla/Styles.md Outdated Show resolved Hide resolved
packages/vanilla/Styles.md Outdated Show resolved Hide resolved
packages/vanilla/Styles.md Outdated Show resolved Hide resolved
sdirix
sdirix reviewed Dec 16, 2020
View reviewed changes
packages/vanilla/Styles.md Outdated Show resolved Hide resolved
sdirix
sdirix reviewed Dec 16, 2020
View reviewed changes
packages/vanilla/README.md Outdated Show resolved Hide resolved
sdirix
sdirix approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sdirix sdirix merged commit bbe2fab into eclipsesource:master Dec 17, 2020
@sdirix sdirix added this to the 2.5.0 milestone Dec 17, 2020
@TheZoker TheZoker deleted the add-styles-context branch December 17, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
documentation react vanilla
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Add description for the new 'JsonFormsStyleContext'
3 participants
@TheZoker @coveralls @sdirix