Fix React Vanilla IntegerCell not rendering zero

The React Vanilla IntegerCell now correctly displays the number 0 instead of an empty string.
eclipsesource · Apr 11, 2022 · 23e1a55 · 23e1a55
1 parent 7e5ac13
commit 23e1a55
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/vanilla/src/cells/IntegerCell.tsx b/packages/vanilla/src/cells/IntegerCell.tsx
@@ -40,7 +40,7 @@ export const IntegerCell = (props: CellProps & VanillaRendererProps) => {
     <input
       type='number'
       step='1'
-      value={data || ''}
+      value={data ?? ''}
       onChange={ev => handleChange(path, parseInt(ev.target.value, 10))}
       className={className}
       id={id}

diff --git a/packages/vanilla/test/renderers/IntegerCell.test.tsx b/packages/vanilla/test/renderers/IntegerCell.test.tsx
@@ -351,4 +351,15 @@ describe('Integer cell', () => {
     const input = wrapper.find('input').getDOMNode() as HTMLInputElement;
     expect(input.disabled).toBe(false);
   });
+
+  test('shows 0 instead of empty string', () => {
+    const core = initCore(fixture.schema, fixture.uischema, { foo: 0 });
+    wrapper = mount(
+      <JsonFormsStateProvider initState={{ core }}>
+        <IntegerCell schema={fixture.schema} uischema={fixture.uischema} path='foo' />
+      </JsonFormsStateProvider>
+    );
+    const input = wrapper.find('input').getDOMNode() as HTMLInputElement;
+    expect(input.value).toBe('0');
+  });
 });