-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for arm64-v8a on Android #380
Conversation
Android builds fail otherwise.
Docker's output must've changed at some point.
I haven't run any unit tests or anything, but the created artifact works with our apps.
I want to use |
You need to build it yourself, unfortunately. I also had trouble getting a proper x86 build going, so I did a frankenbuild. |
Could provide a precompiled |
I had compiled a arm64-v8a |
Turns out this PR is incomplete in other ways too: the armv7 build doesn't work on pre-Lollipop devices. Reverting 7d9c456 "fixes" it, but that means arm64 builds stop working. I'll see if I can get something done about this at some point. |
I found this problem too and now use the official armv7 so file to "solve".Hope can fix in future. |
Is this stalled? Would love to see this merged at some point soon. |
}) | ||
|
||
#----------------------------------------------------------------------- | ||
def build_node_js(config): | ||
return [ | ||
"""android-gcc-toolchain $ARCH --api 17 --host gcc-lpthread -C \ | ||
"""android-gcc-toolchain $ARCH --api 21 --host gcc-lpthread -C \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only need to set api to 21 when build arm64, maybe return different config for different abi.
Seems this is no longer needed. |
Adds support for 64-bit ARM on Android. The end result seems to work in my apps at least. Not sure if this is done in a way that's proper for the project; maybe someone can help me out if not.
I tried getting x86_64 on Android working as well, but with less luck.