Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64-v8a on Android #380

Closed
wants to merge 5 commits into from
Closed

Support for arm64-v8a on Android #380

wants to merge 5 commits into from

Conversation

superjohan
Copy link

Adds support for 64-bit ARM on Android. The end result seems to work in my apps at least. Not sure if this is done in a way that's proper for the project; maybe someone can help me out if not.

I tried getting x86_64 on Android working as well, but with less luck.

Android builds fail otherwise.
Docker's output must've changed at some point.
I haven't run any unit tests or anything, but the created artifact works with our apps.
@44xiao44
Copy link

44xiao44 commented Feb 5, 2018

I want to use .so package that supports arm64. Can I download Maven Central v4.6.0?

@superjohan
Copy link
Author

You need to build it yourself, unfortunately. I also had trouble getting a proper x86 build going, so I did a frankenbuild.

@wwqgtxx
Copy link

wwqgtxx commented Apr 13, 2018

Could provide a precompiled libj2v8.so arm64-v8a lib file before owner pull this pr to help more people need use j2v8 with 64bit library

@wwqgtxx
Copy link

wwqgtxx commented Apr 13, 2018

I had compiled a arm64-v8a libj2v8.so by this branch libj2v8.so, hope can help the people who need.

@drywolf drywolf self-requested a review April 18, 2018 11:25
@drywolf drywolf self-assigned this Apr 18, 2018
@superjohan
Copy link
Author

Turns out this PR is incomplete in other ways too: the armv7 build doesn't work on pre-Lollipop devices. Reverting 7d9c456 "fixes" it, but that means arm64 builds stop working. I'll see if I can get something done about this at some point.

@wwqgtxx
Copy link

wwqgtxx commented May 23, 2018

I found this problem too and now use the official armv7 so file to "solve".Hope can fix in future.

@jordanffs
Copy link

Is this stalled? Would love to see this merged at some point soon.

})

#-----------------------------------------------------------------------
def build_node_js(config):
return [
"""android-gcc-toolchain $ARCH --api 17 --host gcc-lpthread -C \
"""android-gcc-toolchain $ARCH --api 21 --host gcc-lpthread -C \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need to set api to 21 when build arm64, maybe return different config for different abi.

@superjohan
Copy link
Author

Seems this is no longer needed.

@superjohan superjohan closed this Jan 18, 2019
@superjohan superjohan deleted the arm64-support branch January 18, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants