This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[eclipse/xtext#1982] support for java 17 #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szarnekow
reviewed
Oct 10, 2022
| @@ -1774,7 +1774,14 @@ class JavaASTFlattener extends ASTVisitor { | |||
| appendToBuffer("default ") | |||
| } else { | |||
| appendToBuffer("case ") | |||
| node.getExpression().accept(this) | |||
| if (ASTParserFactory.asJLS(targetApiLevel) >= 14) { | |||
There was a problem hiding this comment.
IIRC this is J2X - shall we drop that feature?
szarnekow
approved these changes
Oct 10, 2022
cdietrich
force-pushed
the
cd_platformUpdateExp
branch
from
63215ef to
6bdae51
Compare
cdietrich
changed the title
Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
force-pushed
the
cd_platformUpdateExp
branch
from
6bdae51 to
23f2d52
Compare
cdietrich
added a commit
that referenced
this pull request
Oct 18, 2022
[eclipse-xtext/xtext#1982] support for java 17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[eclipse-xtext/xtext#1982] support for java 17