This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[eclipse/xtext-extras#704] mark JvmMember.identifier non derived + settable #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
am not sure if this could trigger serialilization problems in wired subclasses |
cdietrich
commented
Aug 9, 2021
| @@ -211,7 +211,7 @@ | |||
| <eStructuralFeatures xsi:type="ecore:EAttribute" name="visibility" eType="#//JvmVisibility"/> | |||
| <eStructuralFeatures xsi:type="ecore:EAttribute" name="simpleName" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EString"/> | |||
| <eStructuralFeatures xsi:type="ecore:EAttribute" name="identifier" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EString" | |||
| changeable="false" transient="true" derived="true"/> | |||
| transient="true"/> | |||
There was a problem hiding this comment.
i assume the normal transient value handling will also handle this correct during serialization
|
to test: run org.eclipse.xtext.xbase.tests.serializer.SerializerTest with java 16 on master vs on this branch |
Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
force-pushed
the
cd_jvmTypesTest
branch
from
4cecbe3 to
717db19
Compare
szarnekow
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#704] mark JvmMember.identifier non derived + settable
Signed-off-by: Christian Dietrich [email protected]