This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[eclipse/xtext-core#517] Moved Class File Constant Calculation to JavaVersion Enum #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdietrich
force-pushed
the
cd_core_issue_517
branch
from
d438297 to
c086c11
Compare
szarnekow
approved these changes
Mar 27, 2018
| @@ -228,29 +227,13 @@ public InMemoryJavaCompiler(final ClassLoader parent, final CompilerOptions comp | |||
| InMemoryJavaCompiler.ClassLoaderBasedNameEnvironment _classLoaderBasedNameEnvironment = new InMemoryJavaCompiler.ClassLoaderBasedNameEnvironment(parent); | |||
| this.nameEnv = _classLoaderBasedNameEnvironment; | |||
| this.parentClassLoader = parent; | |||
| Map _map = compilerOptions.getMap(); | |||
| Map<String, String> _map = compilerOptions.getMap(); | |||
There was a problem hiding this comment.
Does this work with Luna TP?
cdietrich
force-pushed
the
cd_core_issue_517
branch
from
c086c11 to
ce3cad9
Compare
|
fixed the generics problem |
…aVersion Enum Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
force-pushed
the
cd_core_issue_517
branch
from
ce3cad9 to
e863408
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[eclipse-xtext/xtext#2578] Moved Class File Constant Calculation to JavaVersion Enum
Signed-off-by: Christian Dietrich [email protected]