This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[#608] Fixed reuse issue with WrappingInjectorProvider #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… global registry even if the delegate itself is a IRegistryConfigurator and its injector is already created so that createInjector does not do anything that could be recorded Signed-off-by: Christian Dietrich <[email protected]>
szarnekow
approved these changes
Jan 15, 2018
kthoms
approved these changes
Jan 16, 2018
Closed
cdietrich
commented
Aug 2, 2021
| @@ -45,8 +45,14 @@ public WrappingInjectorProvider(IInjectorProvider delegate) { | |||
| this.delegate = delegate; | |||
| stateBeforeInjectorCreation = GlobalRegistries.makeCopyOfGlobalState(); | |||
| this.injector = createInjector(); | |||
| if (delegate instanceof IRegistryConfigurator) { | |||
There was a problem hiding this comment.
is it correct to call this AFTER createInjector?
There was a problem hiding this comment.
nope inverting also seems to break other stuff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#608] make sure that WrappingInjectorProvider records changes to the global registry even if the delegate itself is a IRegistryConfigurator and its injector is already created so that createInjector does not do anything that could be recorded
Signed-off-by: Christian Dietrich [email protected]