Skip to content
This repository was archived by the owner on Apr 21, 2023. It is now read-only.

Update to Gradle 7 in Wizard #1727

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Update to Gradle 7 in Wizard #1727

merged 2 commits into from
Aug 10, 2021

Conversation

cdietrich
Copy link
Member

[#1726] update wizard to gradle 7

@cdietrich cdietrich added this to the Release_2.26 milestone Jul 23, 2021
@cdietrich cdietrich force-pushed the cd_gradle7inWizard branch 2 times, most recently from 01ef815 to 102596a Compare July 23, 2021 13:09
@cdietrich cdietrich requested a review from oehme July 26, 2021 07:57
@cdietrich
Copy link
Member Author

for tests: xtext/xtext-reference-projects#196

@cdietrich cdietrich linked an issue Aug 9, 2021 that may be closed by this pull request
Copy link
Member

@oehme oehme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small remark.

}
configurations {
mwe2 {
extendsFrom compile
extendsFrom api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extend from compileClasspath here, since that also includes things like compileOnly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will give this a try

Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
@cdietrich cdietrich merged commit ab1982d into master Aug 10, 2021
@cdietrich cdietrich deleted the cd_gradle7inWizard branch August 10, 2021 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Wizard to Gradle 7
2 participants