Java 11+ hates some of the reflection stuff we do

[cdietrich]

e.g.

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.eclipse.xtext.util.MergeableManifest (file:/C:/Users/aart/eclipse/plugins/org.eclipse.xtext.util_2.13.0.v20171005-0628.jar) to field java.util.jar.Manifest.attr
WARNING: Please consider reporting this to the maintainers of org.eclipse.xtext.util.MergeableManifest
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

[cdietrich]

More places:

• the version of guice we use results in WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$2 (file:/home/dietrich/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/3.0/9d84f15fe35e2c716a02979fb62f50a29f38aefa/guice-3.0.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) see Update to Guice 5.0.1+ #393 and Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1  google/guice#1133

[cdietrich]

no news on guice side

[cdietrich]

move to 2.22

[cdietrich]

still waiting for guice fix to be released. move to 2.24

[wmanth]

Any news on that? Would be reducing the extensive use of dependency injection an option?
Some people (or is it just me?) anyway have problems understanding what's going on and how to fix things if they don't work as expected.

And obviously Guice is not a well behaving first class citizen on Java >8 anymore.

[cdietrich]

there is a guice 5 beta out containing a fix.
but that brings other problems
so it will take some time to integrate it
once it is release

see also #393
you might also experiment using guice 3/4 noaop

[cdietrich]

as there is still no guice release: move to 2.25

[cdietrich]

as there is still no guice release: move to 2.26

[melaasar]

I think there is a release now: https://github.com/google/guice/releases/tag/5.0.1

[cdietrich]

@melaasar fee free to test with the information in #393

[cdietrich]

TODO: milestone & bootstrapping test

[cdietrich]

there is also still some warnings in tycho/pde that needs tested with new version
update: these warnings are about security manager. so a different thing
it's also fixed in 2.5
=> only thing left is bootstrapping

[cdietrich]

done