Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify/Delete Mappings #235

Closed
eselmeister opened this issue Nov 21, 2020 · 10 comments
Closed

Modify/Delete Mappings #235

eselmeister opened this issue Nov 21, 2020 · 10 comments
Assignees

Comments

@eselmeister
Copy link
Contributor

It would be nice to edit the mappings, e.g.

  • Delete
  • Import
  • Export
  • Reset

Bildschirmfoto von 2020-11-21 08-39-01

@Tanmay2510
Copy link

Tanmay2510 commented Mar 1, 2021

@eselmeister Sir, do the buttons(DELETE,Export,Reset,Import) need to be put inside the setting mappings UI beside the Ok and Exit button or it should be aligned with extended legend buttons?

@eselmeister
Copy link
Contributor Author

eselmeister commented Mar 1, 2021 via email

@Tanmay2510
Copy link

@eselmeister Sir, I am stuck. I am unable to create any changes/or create a button inside the "Setting Mappings" dialog. And even if I create a button it gets placed in extended legend. Could you please help me?

@eselmeister
Copy link
Contributor Author

eselmeister commented Mar 6, 2021 via email

@Tanmay2510
Copy link

Tanmay2510 commented Mar 7, 2021

Tanmay, try harder to find a solution :-). Best, Philip Am 06.03.21 um 09:42 schrieb Tanmay Raikwar:

@eselmeister https://github.com/eselmeister Sir, I am stuck. I am unable to create any changes/or create a button inside the "Setting Mappings" dialog. And even if I create a button it gets placed in extended legend. Could you please help me? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT3EHNCZ7CYYO3CDZZ3TCHTHJANCNFSM4T5UAPZA.
-- ~~~~~~~~~~~~~~~~~~~~~~~~ OpenChrom - the open source alternative for chromatography / mass spectrometry Dr. Philip Wenig » Founder » [email protected] » http://www.openchrom.net ~~~~~~~~~~~~~~~~~~~~~~~~
Update: Successfully created a button inside the Mapping Setting dialog.
ButtonsEclipse

@eselmeister eselmeister self-assigned this May 22, 2021
@eselmeister
Copy link
Contributor Author

A refresh is required when the mapped settings are deleted. Importing settings automatically tries to match the settings.

Bildschirmfoto von 2021-05-22 09-56-27

Bildschirmfoto von 2021-05-22 09-57-12

Bildschirmfoto von 2021-05-22 09-57-24

Please note, the settings ids might change in the future. Hence, the settings export/import is intended to be used in a short period of time.

Bildschirmfoto von 2021-05-22 09-57-46

Bildschirmfoto von 2021-05-22 09-58-15

Bildschirmfoto von 2021-05-22 09-58-20

@eselmeister
Copy link
Contributor Author

I have an idea how to enable the reset functionality without hassles.

@eselmeister
Copy link
Contributor Author

This is a complex issue :-). I have recognized, that the export dialog changes the settings too. The export shall only change the series settings temporarily.

@eselmeister
Copy link
Contributor Author

The mappings dialog has been modified. It's possible to reset selected and all mappings. It will replace the changes by the defaults. Remove all clears the mappings as well as the defaults. The next time, a change is made to the settings, a new default is created.

Bildschirmfoto von 2021-05-25 07-03-48

Bildschirmfoto von 2021-05-25 07-03-52

The export option works fine now.

Bildschirmfoto von 2021-05-25 07-04-12

@eselmeister
Copy link
Contributor Author

Though this issue was a bit more complex than anticipated, many issues needed for the following issue have been implemented yet:
#236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants