-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the official Eclipse Hono 1.0.3 chart #25
Conversation
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
f696cd7
to
d1cb52c
Compare
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Hono chart should align with the other charts and simply named hono
. Also should the images be configured as explained by @monotek and already done in the other two projects:
image:
## repository for the concierge docker image
repository: docker.io/eclipse/ditto-concierge
## tag for the concierge docker image
tag: 1.0.0
## pullPolicy for the concierge docker image
pullPolicy: IfNotPresent
Signed-off-by: Kai Hudalla <[email protected]>
Signed-off-by: Kai Hudalla <[email protected]>
@ctron @monotek this PR was just meant as a test to verify if the original/unaltered chart would pass all checks, which it seems to do (apart from some formal modifications to please the linter). |
Imho the chart should not be published here unter 2 different names. As mentioned before, when the chart is published here, it will be made available via https://hub.helm.sh/charts?q=eclipse too. I guess it's better to keep the "eclipse-hono" chart where it is now and publish it as "hono" chart here, when you're ready to do so. |
I am afraid that this might introduce quite some delay because in the Hono project we will need to figure out first if and how we want to move the development of the Hono chart to IoT Packages. If we agree to not move the chart, then we might need to wait until Hono 1.1.0 before we can add a Hono chart to IoT Packages. I am not sure if we can afford this delay wrt package zero ... |
Maybe a temporary copy of your current state as "hono" chart would work too? |
closing in favor of #28 |
This is just a test to see if the CI pipeline succeeds, do not merge.