Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new formatting setting xml.format.splitAttributesIndentSize #952

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented Dec 22, 2020

Add a new setting which controls the level of indentation of attributes with respect to their parent element when xml.format.splitAttributes is enabled.

Based off of a comment by Cong Wang (@I322871) on the vscode-xml Gitter

Signed-off-by: David Thompson [email protected]

@datho7561
Copy link
Contributor Author

datho7561 commented Dec 22, 2020

  • Write tests

@datho7561
Copy link
Contributor Author

Please test with redhat-developer/vscode-xml#386

@datho7561 datho7561 changed the title Add new formatting setting xml.format.numberOfIndentsForSplitAttributes Add new formatting setting xml.format.splitAttributesIndentSize Dec 23, 2020
@datho7561
Copy link
Contributor Author

datho7561 commented Dec 23, 2020

need to rename commit... done

Adds a new setting which controls the level of indentation of attributes
with respect to their parent element when `xml.format.splitAttributes`
is enabled.

Based off of a comment by Cong Wang (@I322871) on the vscode-xml Gitter

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 requested a review from angelozerr December 23, 2020 14:58
@angelozerr angelozerr merged commit 200a7aa into eclipse-lemminx:master Dec 23, 2020
@datho7561 datho7561 deleted the only-one-tab branch December 23, 2020 18:44
@angelozerr angelozerr added this to the 0.15.0 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants