Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LemMinX crashes if one extension class cannot be created #967

Closed
angelozerr opened this issue Jan 19, 2021 · 0 comments · Fixed by #968
Closed

LemMinX crashes if one extension class cannot be created #967

angelozerr opened this issue Jan 19, 2021 · 0 comments · Fixed by #968
Assignees
@angelozerr
Labels
bug Something isn't working
Milestone
0.15.0

Comments

@angelozerr
Copy link
Contributor

I had this issue when I testing lemminx-maven in Eclipse IDE (a problem with Java compiler on my side). I notice when one extension class cannot be instanciated it crashes the XML LS and we loose all XML features (completion, diagnostics, etc).

To test this problem,you can add in the org.eclipse.lemminx.services.extensions.IXMLExtension

BAD_CLASS and you try to start test, everything is broken.
@angelozerr angelozerr added the bug Something isn't working label Jan 19, 2021
@angelozerr angelozerr added this to the 0.15.0 milestone Jan 19, 2021
@angelozerr angelozerr self-assigned this Jan 19, 2021
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jan 19, 2021
@angelozerr
LemMinX crashes if one extension class cannot be created
0bec2cc 
Fixes eclipse-lemminx#967

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jan 19, 2021
Merged
datho7561 pushed a commit that referenced this issue Jan 19, 2021
@angelozerr @datho7561
LemMinX crashes if one extension class cannot be created
4e58859 
Fixes #967

Signed-off-by: azerr <[email protected]>
@rgrunber rgrunber mentioned this issue Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

LemMinX crashes if one extension class cannot be created angelozerr/lemminx
1 participant
@angelozerr