Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LemMinX crashes if one extension class cannot be created #968

Merged
merged 1 commit into from
Jan 19, 2021
Merged

LemMinX crashes if one extension class cannot be created #968

merged 1 commit into from
Jan 19, 2021

Conversation

angelozerr
Copy link
Contributor

LemMinX crashes if one extension class cannot be created

Fixes #967

Signed-off-by: azerr [email protected]

@angelozerr angelozerr requested a review from datho7561 January 19, 2021 17:03
@angelozerr
Copy link
Contributor Author

angelozerr commented Jan 19, 2021 •
edited
Loading

I could add test by adding the file src/test/resources/META-INF/serves/org.eclipse.lemminx.services.extensions.IXMLExtension with the content BAD-CLASS and tests should continue to work, but I would like to avoid doing that otherwise we will see a lot of logs for tests.

datho7561
datho7561 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561 datho7561 merged commit 4e58859 into eclipse-lemminx:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LemMinX crashes if one extension class cannot be created
2 participants
@angelozerr @datho7561