Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[databroker] Update calls to subscribe #692

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[databroker] Update calls to subscribe #692

merged 1 commit into from
Oct 25, 2023

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Oct 25, 2023

Internal subscribe function signature was modified and not all call sites got updated.

@argerus
[databroker] Update calls to subscribe
d73282c 
Internal subscribe function signature was modified and not all call
sites got updated.
erikbosch
erikbosch approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all builds pass, so will merge it

@erikbosch erikbosch merged commit 170ed8b into eclipse:master Oct 25, 2023
13 checks passed
@erikbosch erikbosch deleted the feature/fix_subscribe_callers branch October 25, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikbosch erikbosch erikbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argerus @erikbosch