Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all valid vss paths #678

Merged

Conversation

rafaeling
Copy link
Contributor

@rafaeling rafaeling commented Oct 2, 2023

Databroker now accepts any path composed of any character except : and whitespace, i.e.

- Vehicle._kuksa.databroker.GitVersion
- Vehicle.Do_you_not_like_smörgåstårta
- Vehicle.tschö_mit_ö
- Vehicle.東京_Москва_r#true

Copy link
Contributor

@argerus argerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes still include validation of paths "sprinkled" throughout the code.

As discussed and concluded in the corresponding issue (#674), a better approach would be to add validation only at the point of adding new entries (i.e. here).

@rafaeling rafaeling force-pushed the fix/support_all_valid_vss_paths branch from 050aeca to aa8526a Compare October 18, 2023 10:06
@SebastianSchildt
Copy link
Contributor

We should work on getting Vehicle._kuksa.databroker.GitVersion.Do_you_not_like_smörgåstårta.tschö_mit_ö.東京_Москва_r#true into the VSS standard catalogue :)

@SebastianSchildt SebastianSchildt merged commit 258f349 into eclipse:master Oct 18, 2023
13 checks passed
@erikbosch erikbosch deleted the fix/support_all_valid_vss_paths branch October 31, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants