-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kuksa-client] Show subscription events in client. #648
[kuksa-client] Show subscription events in client. #648
Conversation
argerus
commented
Sep 4, 2023
- Show subscription events in client instead of writing them to a file (and suggesting the user tails them manually).
- Show subscription events in client instead of writing them to a file (and suggesting the user tails them manually).
caabbd2
to
13a5c40
Compare
Looks good to me. What we possibly could discuss, not necessarily part of this PR, is if we would like to align output format for |
The tail CAN be annoying sometimes, but how does this Pr influence the ability to "keep working" while several subscriptions running? Maybe this should be more like an option? |
Good point. I just got annoyed by this indirection, but I guess it can be feature in some cases. I added an option to enable old behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works. Nice little quality-of-life-improvement for some use cases without breaking others 🥳