Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting value "NotAvailable" #646

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Support setting value "NotAvailable" #646

merged 1 commit into from
Sep 5, 2023

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Sep 4, 2023 •
edited
Loading

Add the ability to set a value as being not available (i.e. the initial state of a signal that is not set).

SebastianSchildt
SebastianSchildt approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me,

I do think there is the Corner case that a string signal can not be set to literal "NotAvailable" anymore, but as this is just a choice made by the client and not an API issue as such I think it is fine (alternative would be an "unset" call)

@SebastianSchildt SebastianSchildt merged commit 77e082e into eclipse:master Sep 5, 2023
10 checks passed
@erikbosch erikbosch deleted the feature/support_not_available branch October 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianSchildt SebastianSchildt SebastianSchildt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argerus @SebastianSchildt