Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared SPDX action #643

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

SebastianSchildt
Copy link
Contributor

This iuses the shared SPDX action in the new Orga. Should not change anyhting functionality wise.

I am however not sure if deleting the action itself has neagative side effects in case it is used elsewhere. If other repos refer to a tag, no issue, if they refer to no reference or master it needs further PRs in the other Repos. Any idea @erikbosch ?

Signed-off-by: Sebastian Schildt <[email protected]>
@erikbosch
Copy link
Contributor

Don't you need to change https://github.com/eclipse/kuksa.val/blob/master/.github/workflows/check_license.yaml so that it uses the action from the new location (i.e. https://github.com/eclipse-kuksa/kuksa-actions)

Yes, it is true that other workflows in other repos might need to be changed (like https://github.com/eclipse/kuksa.val.feeders/blob/main/.github/workflows/check_license.yaml) but that is wanted. Using latest master/main is always risky :-)

@SebastianSchildt
Copy link
Contributor Author

Don't you need to change https://github.com/eclipse/kuksa.val/blob/master/.github/workflows/check_license.yaml so that it uses the action from the new location (i.e. https://github.com/eclipse-kuksa/kuksa-actions)

I need, I did, I didn't push, hopefully fixed now

Signed-off-by: Sebastian Schildt <[email protected]>
@@ -21,8 +21,8 @@ jobs:
- name: Set license
run: |
echo "licenses=Apache-2.0" >> $GITHUB_ENV

- uses: ./.github/actions/spdx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove trailing whitespaces on line 10 as well

@erikbosch erikbosch merged commit 92cc002 into eclipse:master Sep 5, 2023
2 checks passed
@SebastianSchildt SebastianSchildt deleted the feature/shared_spdx_action branch February 29, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants