Fixing build action triggers #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmittag
requested changes
Jul 31, 2023
| - ".github/workflows/kuksa_val_docker.yml" | ||
| - "kuksa-val-server/**" | ||
| - "kuksa_certificates/**" | ||
| - "proto/**" |
There was a problem hiding this comment.
do we need proto here? Server doesn't use it or am I wrong?
There was a problem hiding this comment.
Correct, good catch, it uses it's own proto file at https://github.com/eclipse/kuksa.val/blob/master/kuksa-val-server/protos/kuksa.proto. Will update
lukasmittag
approved these changes
Jul 31, 2023
But that is not in the Proto folder, it is in https://github.com/eclipse/kuksa.val/blob/master/kuksa-val-server/protos/kuksa.proto |
|
The databroker failed build is related to #631 |
lukasmittag
approved these changes
Aug 1, 2023
|
Pls rebase to master to see it runs through now |
Rationale: Kuksa-val build was triggered too often, But then, should we not trigger when certs and proto files are changed as well (Even if some use symbolic links)
SebastianSchildt
force-pushed
the
erik_docker
branch
from
1d88a10
to
c09ba65
Compare
SebastianSchildt
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
Kuksa-val build was triggered too often due to negative requirement and a spelling error
Clean-images is useless as we do not upload images tagged by PR
But then, should we not trigger when certs and proto files are changed as well (Even if some use symbolic links, do not know if build action is smart enough to follow symbolic links and check if they have been changed))
Note: Not intended for v0.4!