Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lazy loading to the MALDI ion table #910

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

Mailaender
Copy link
Contributor

This is meant to improve performance.

@eselmeister
Copy link
Contributor

When opening a file in the MALDI-TOF perspective, the m/z list stays empty. Is that intended?

Bildschirmfoto von 2022-02-19 11-03-36

@Mailaender Mailaender marked this pull request as draft February 21, 2022 16:12
@Mailaender Mailaender marked this pull request as ready for review February 26, 2022 21:40
@Mailaender
Copy link
Contributor Author

Updated.

@eselmeister
Copy link
Contributor

The lazy modus works now. But the table is not updated correctly, if another mass spectrum was loaded previously.

Bildschirmfoto vom 2022-02-28 09-33-53

How to test this:

  1. Load e.g. a chromatogram via the data analysis perspective.
  2. Then navigate to the MALDI-TOF perspective.
  3. Select a scan in the previously loaded chromatogram, it shall be displayed in the m/z list.
  4. Then load the MALDI-TOF file. The previously selected scan remains in the list.

@Mailaender
Copy link
Contributor Author

I removed the broken lazy loading.

@eselmeister eselmeister merged commit ca1c0e2 into eclipse:develop Feb 28, 2022
@Mailaender Mailaender deleted the maldi-lazy-ions branch February 28, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants