Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Scan Chart performance #904

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

Mailaender
Copy link
Contributor

I noticed some jank when clicking in the peak/scan list that is very visible when databases are not configured.

@eselmeister
Copy link
Contributor

The progress dialog has been introduced to show a progress as loading a large database initially could take a while. I will review the change again, but some issue currently exist:

Please remove the System.out:
System.out.println(file.getAbsolutePath());

This cange causes two errors in the template processor:

The method run() in the type LibraryServiceRunnable is not applicable for the arguments (NullProgressMonitor)	ExtendedComparisonUI.java	/net.openchrom.xxd.process.supplier.templates.ui/src/net/openchrom/xxd/process/supplier/templates/ui/swt/peaks	line 106	Java Problem
The method run(boolean, boolean, IRunnableWithProgress) in the type ProgressMonitorDialog is not applicable for the arguments (boolean, boolean, LibraryServiceRunnable)	ExtendedComparisonUI.java	/net.openchrom.xxd.process.supplier.templates.ui/src/net/openchrom/xxd/process/supplier/templates/ui/swt/peaks	line 101	Java Problem

@Mailaender
Copy link
Contributor Author

I am modifying the wrong end of the problem. Removed the second commit and the sysout debug line.

@eselmeister eselmeister merged commit 3eeaccf into eclipse:develop Feb 17, 2022
@Mailaender Mailaender deleted the scanchart-perf branch February 17, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants