Added undo/redo for peak/scan deletion #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
undo
branch
2 times, most recently
from
eeae90e to
ba1b748
Compare
|
It's a huge change. But I agree, that the do/redo/undo for chromatogram instances was too heavy. Each and every time, a complete dump of the chromatograms was created, which ensured the consistency of the data, but was slow. Hence, it was deactivated for a while, but the code wasn't removed. After reviewing this change thoroughly, I agree to remove the unused version management. It's a clever idea to use the Eclipse Do/Undo/Redo pattern. |
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #887