Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HPLC-DAD .ocb peak import #858

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

Mailaender
Copy link
Contributor

Closes #857

@eselmeister
Copy link
Contributor

Yep, that could be a fix for the problem. But

peakMaximum.addScanSignal(new ScanSignalWSD(0, totalSignalScan));

sets a peak without any wavelength information. A peak could consist of several wavelengths when using HPLC-DAD. In case of HPLC-UV/Vis, most commonly only one wavelength at a time is used. Probably, we should create a new version soon, that also allows to store n wavelengths for a WSD peak. Additionally, the adjustTotalIntensity might need improvements. In case of GC-MS it's easy as only positive values occur. In case GC-FID, we have only one signal. In case of HPLC-UV/Vis too. But with HPLC-DAD, positive and negative signals might be available.

Give me some time to think about side-effects regarding this PR. I'll come to a decision today.

@Mailaender
Copy link
Contributor Author

@eselmeister
Copy link
Contributor

Yep, that was also the right choice. In a next version, we should improve the HPLC-DAD peak handling. Let's chat.

@eselmeister eselmeister merged commit 90e0e0a into eclipse:develop Jan 5, 2022
@Mailaender Mailaender deleted the wsd-peak-import branch January 5, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPLC-DAD files don't save peaks
2 participants