Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a regression in column type labeling #804

Merged
merged 5 commits into from
Nov 3, 2021

Conversation

Mailaender
Copy link
Contributor

Closes #803

@eselmeister
Copy link
Contributor

I was not able to reproduce the error so far. The error message is thrown in the calculateIndices(...) method of the class:
org.eclipse.chemclipse.chromatogram.xxd.calculator.supplier.amdiscalri.impl.RetentionIndexCalculator

IMHO, I doubt that the runnable is involved here. It seems to be, that the RI entries can't be fetched:

ISeparationColumnIndices separationColumnIndices = getSeparationColumnIndices(chromatogramSelection, calculatorSettings);
if(separationColumnIndices != null) {
	...
} else {
	processingInfo.addErrorMessage(DESCRIPTION, "The retention index map could not be found. Is a calibration (*.cal) file or chromatogram RI map available?");
}

We could try to delete the user preference and start the process again.

@Mailaender
Copy link
Contributor Author

Hmm, yes this only seems to swallow the exception, no RIs are calculated and it still shows errors. See #803 (comment)

@Mailaender Mailaender marked this pull request as draft November 2, 2021 12:43
@Mailaender Mailaender marked this pull request as ready for review November 2, 2021 14:41
@Mailaender Mailaender changed the title Fixed a null reference exception in Retention Index Calculator Fixed a regression in column type labeling Nov 2, 2021
@Mailaender
Copy link
Contributor Author

Okay, I can now confirm that this calculates retention indices again.

@eselmeister
Copy link
Contributor

Is it on purpose that SEMI-POLAR is flipped in SeparationColumnType?

DEFAULT("Default", "DEFAULT"), //
POLAR("Polar", "POLAR"), //
APOLAR("Nonpolar", "APOLAR"), //
SEMI_POLAR("SEMI-POLAR", "Semipolar"),

@Mailaender
Copy link
Contributor Author

No, I was hasty there. Fixed.

@eselmeister eselmeister merged commit bab8237 into eclipse:develop Nov 3, 2021
@Mailaender Mailaender deleted the ri-calc-null branch February 8, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled event loop exception in Retention Index Calculator
2 participants