Close the file when things go wrong.

eclipse · Nov 2, 2021 · 7491b78 · 7491b78
1 parent 29247c7
commit 7491b78
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/....calculator/src/org/eclipse/chemclipse/chromatogram/xxd/calculator/io/AMDISConverter.java b/....calculator/src/org/eclipse/chemclipse/chromatogram/xxd/calculator/io/AMDISConverter.java
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2018, 2020 Lablicate GmbH.
+ * Copyright (c) 2018, 2021 Lablicate GmbH.
  * 
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
@@ -50,8 +50,7 @@ public ISeparationColumnIndices parse(File file) {
 
 		ISeparationColumnIndices separationColumnIndices = new SeparationColumnIndices();
 		//
-		try {
-			BufferedReader bufferedReader = new BufferedReader(new FileReader(file));
+		try (BufferedReader bufferedReader = new BufferedReader(new FileReader(file))) {
 			/*
 			 * Column Specification
 			 */
@@ -119,8 +118,6 @@ public ISeparationColumnIndices parse(File file) {
 			 */
 			ISeparationColumn separationColumn = new SeparationColumn(name, length, diameter, phase);
 			separationColumnIndices.setSeparationColumn(separationColumn);
-			//
-			bufferedReader.close();
 		} catch(IOException e) {
 			logger.error(e);
 		}

diff --git a/...ipse/chemclipse/chromatogram/xxd/identifier/supplier/file/model/IdentifierFileReader.java b/...ipse/chemclipse/chromatogram/xxd/identifier/supplier/file/model/IdentifierFileReader.java
@@ -48,8 +48,7 @@ private ISeparationColumn extractSeparationColumn(File file) {
 		 */
 		ISeparationColumn separationColumn = SeparationColumnFactory.getSeparationColumn(SeparationColumnFactory.TYPE_DEFAULT);
 		//
-		try {
-			BufferedReader bufferedReader = new BufferedReader(new FileReader(file));
+		try (BufferedReader bufferedReader = new BufferedReader(new FileReader(file))) {
 			/*
 			 * Column Specification
 			 */
@@ -81,7 +80,6 @@ private ISeparationColumn extractSeparationColumn(File file) {
 			 * Create the column.
 			 */
 			separationColumn = new SeparationColumn(name, length, diameter, phase);
-			bufferedReader.close();
 		} catch(IOException e) {
 			logger.error(e);
 		}