-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QoS configuration overwrites for publication messages #1613
Merged
OlivierHecart
merged 30 commits into
eclipse-zenoh:main
from
ZettaScaleLabs:qos/pub-builders-config
Dec 4, 2024
Merged
Add QoS configuration overwrites for publication messages #1613
OlivierHecart
merged 30 commits into
eclipse-zenoh:main
from
ZettaScaleLabs:qos/pub-builders-config
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR missing one of the required labels: {'internal', 'enhancement', 'breaking-change', 'dependencies', 'bug', 'new feature', 'documentation'} |
Converting to Draft to apply the following changes:
|
oteffahi
changed the title
Add QoS configuration overwrites for publisher builder
Add QoS configuration overwrites for publication messages
Dec 4, 2024
OlivierHecart
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables users to overwrite QoS parameters for publication messages through config file. These overwrites will apply over Zenoh API configurations.
Overwrites are defined per key expression, which will apply the config on publications with key expressions included (as in the relationship of inclusion between key expressions) in the configured key expressions.
The new config format is the following. Note that config fields are
Option
s, users don't have to overwrite everything.