Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config parsing and warning logs for TLS and QUIC links #1600

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix config parsing and warning logs for TLS and QUIC links #1600

merged 2 commits into from
Nov 20, 2024

Conversation

oteffahi
Copy link
Contributor

Fixes the following issues:

  • Warning should be logged when servername verification is disabled by client, but it was logged when enabled.
  • TLS_VERIFY_NAME_ON_CONNECT was set to false when not provided, but the default value should be TLS_VERIFY_NAME_ON_CONNECT_DEFAULT which is set to true.
  • Default value for TLS_ENABLE_MTLS was hardcoded instead of using a constant.

@oteffahi oteffahi requested a review from gabrik November 20, 2024 14:16
@oteffahi oteffahi added the bug Something isn't working label Nov 20, 2024
@oteffahi oteffahi changed the title Fix argument parsing and warning logs for TLS and QUIC links Fix config parsing and warning logs for TLS and QUIC links Nov 20, 2024
@gabrik gabrik merged commit 3404e05 into eclipse-zenoh:main Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrik gabrik gabrik approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oteffahi @gabrik