Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpg key_id and apply naming convention #18

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add gpg key_id and apply naming convention #18

merged 2 commits into from
Nov 12, 2024

Conversation

heurtematte
Copy link
Contributor

Related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5255

This issue have an impact on the following projects:

Please update their workflow according to the renaming.

Signed-off-by: sebastien.heurtematte <[email protected]>
Signed-off-by: sebastien.heurtematte <[email protected]>
@heurtematte heurtematte requested a review from a team as a code owner November 12, 2024 15:19
Copy link

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

Copy link

This is your friendly self-service bot.

The author (heurtematte) of this PR is associated with this organization in the role of MEMBER.

Additionally, heurtematte is a member of the following teams:

Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for c605ec9
Organization iot.zenoh[id=eclipse-zenoh]

-  remove org_secret[name="SSH_PASSPHRASE"] {
-    name                              = "SSH_PASSPHRASE"
-    selected_repositories             = []
-    value                             = "pass:bots/iot.zenoh/gpg/passphrase"
-    visibility                        = "public"
-  }

-  remove org_secret[name="SSH_PRIVATE_KEY"] {
-    name                              = "SSH_PRIVATE_KEY"
-    selected_repositories             = []
-    value                             = "pass:bots/iot.zenoh/gpg/secret-subkeys.asc"
-    visibility                        = "public"
-  }

+  add org_secret[name="ORG_GPG_KEY_ID"] {
+    name                              = "ORG_GPG_KEY_ID"
+    selected_repositories             = []
+    value                             = "pass:bots/iot.zenoh/gpg/key_id"
+    visibility                        = "public"
+  }

+  add org_secret[name="ORG_GPG_PASSPHRASE"] {
+    name                              = "ORG_GPG_PASSPHRASE"
+    selected_repositories             = []
+    value                             = "pass:bots/iot.zenoh/gpg/passphrase"
+    visibility                        = "public"
+  }

+  add org_secret[name="ORG_GPG_PRIVATE_KEY"] {
+    name                              = "ORG_GPG_PRIVATE_KEY"
+    selected_repositories             = []
+    value                             = "pass:bots/iot.zenoh/gpg/secret-subkeys.asc"
+    visibility                        = "public"
+  }
  
  Plan: 3 to add, 0 to change, 2 to delete.

Warnings

  • some of requested changes require secrets, need to apply these changes manually

cc @eclipse-zenoh/eclipsefdn-security

cc @eclipse-zenoh/eclipsefdn-releng

Copy link

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

@heurtematte heurtematte changed the title Add gpg key_id Add gpg key_id and apply naming convention Nov 12, 2024
@netomi netomi merged commit b372ba1 into main Nov 12, 2024
3 checks passed
@netomi netomi deleted the feat/gpg_key_id branch November 12, 2024 15:33
Copy link

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization iot.zenoh[id=eclipse-zenoh]

-  remove org_secret[name="SSH_PASSPHRASE"] {
-    name                              = "SSH_PASSPHRASE"
-    selected_repositories             = []
-    value                             = "pass:bots/iot.zenoh/gpg/passphrase"
-    visibility                        = "public"
-  }

-  remove org_secret[name="SSH_PRIVATE_KEY"] {
-    name                              = "SSH_PRIVATE_KEY"
-    selected_repositories             = []
-    value                             = "pass:bots/iot.zenoh/gpg/secret-subkeys.asc"
-    visibility                        = "public"
-  }

  
  Applying changes:


  Done.
  
  Executed plan: 0 added, 0 changed, 2 deleted.

Note

The pull request was only partially applied as it requires some access to secrets or the Web UI,
please apply the remaining changes manually and confirm with replying with /otterdog done.

cc @eclipse-zenoh/eclipsefdn-security

cc @eclipse-zenoh/eclipsefdn-releng

@netomi
Copy link
Contributor

netomi commented Nov 12, 2024

/otterdog done

Copy link

This is your friendly self-service bot. The PR has been marked as being completed.

diogomatsubara added a commit to ZettaScaleLabs/ci that referenced this pull request Nov 12, 2024
As per eclipse-zenoh/.eclipsefdn#18, secrets
were updated to follow eclipse foundation naming convention.
diogomatsubara added a commit to ZettaScaleLabs/zenoh-pico that referenced this pull request Nov 12, 2024
As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.
diogomatsubara added a commit to ZettaScaleLabs/zenoh-cpp that referenced this pull request Nov 12, 2024
As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.
J-Loudet pushed a commit to eclipse-zenoh/zenoh-cpp that referenced this pull request Nov 12, 2024
As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.
J-Loudet pushed a commit to eclipse-zenoh/zenoh-pico that referenced this pull request Nov 12, 2024
As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.
J-Loudet pushed a commit to eclipse-zenoh/ci that referenced this pull request Nov 12, 2024
As per eclipse-zenoh/.eclipsefdn#18, secrets
were updated to follow eclipse foundation naming convention.
gabrik pushed a commit to eclipse-zenoh/zenoh-pico that referenced this pull request Nov 14, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* fix: rebase shenanigans

* feat: set batching api as unstable

---------

Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: DenisBiryukov91 <[email protected]>
Co-authored-by: Denis Biryukov <[email protected]>
Co-authored-by: Diogo Mendes Matsubara <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
gabrik pushed a commit to eclipse-zenoh/zenoh-pico that referenced this pull request Nov 18, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* Implement liveliness support (#632)

* fix: merge shenanigans

* fix: integration test issues

* fix: missing send reply final

* fix: liveliness double free

---------

Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: DenisBiryukov91 <[email protected]>
Co-authored-by: Denis Biryukov <[email protected]>
Co-authored-by: Diogo Mendes Matsubara <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
gabrik pushed a commit to eclipse-zenoh/zenoh-pico that referenced this pull request Nov 19, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* Implement liveliness support (#632)

* Mark liveliness API as unstable and disable by default

* Fix typo (#787)

* fix: correct 1.1 issues

* feat: add zp_batch_flush

* fix: switch to #if 0 to deactivate tcp function

---------

Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: DenisBiryukov91 <[email protected]>
Co-authored-by: Denis Biryukov <[email protected]>
Co-authored-by: Diogo Mendes Matsubara <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
gabrik pushed a commit to eclipse-zenoh/zenoh-pico that referenced this pull request Nov 20, 2024
* Update closure handlers documentaion (#736)

* Rename closure callback/dropper types (#739)

* Remove legacy z_zint_t from public API (#741)

* Add `export "C"` for all header files (#740)

* Add `export "C"` for proper closures callbacks export

* Add `export "C"` for all headers

* add serialize from substr functions (#742)

* Rename z_loaned_hello_handler_t to z_closure_hello_callback_t (#743)

* Mark z_reply_replier_id as unstable (#745)

* Add documentation about logging (#744)

* Update README.md (#746)

* hardcode clang-format runner to Ubuntu24.04 (#748)

* fix build granularity (#747)

* fix: badly named constant (#750)

* fix packages

* fix: update debian packaging

- include libzenohpico.so in debian package
- change the package name to libzenohpico in line with libzenohc
- set correct debian version for pre releases
- fix wrong version used in Release mode

* fix: debian dev package name

* fix: package version for releases (#753)

* fix: debian_version for official releases

otherwise they would be undefined

* fix: align cpack version with zenoh-c

* chore: review comments

move cpack version closer to where it's used

* build shared lib for packages instead of static one (#757)

* Fix z_task cleanup for platforms with pthread support (#759)

* Fix read/lease task cleanup (#760)

* Align ID string representation with zenoh (lowercase) (#761)

* Remove default parameters from z_closure (#755)

* build both libraries:shared and static when packaging; (#766)

add static library to dev package;

* Publish debian packages (#769)

* fix: add workflow to release debian packages

* fix: align with zenoh-c

- update package names
- set version string in the same way
- set DEBARCH/RPMARCH
- set CPACK_PACKAGE_FILE_NAME
- add -j to zip archive to not include parent folder

* fix: use CPACK_PACKAGE_NAME

* fix: pass package name to all build targets

* fix: Don't tag release branch during dry-run

* Replace exit with return in zephyr examples (#774)

* Add platform_common.c to zephyr CMakeLists.txt file

* Rework Zenoh ID conversion

* chore: Update org secrets (#782)

As per eclipse-zenoh/.eclipsefdn#18, secrets were updated to follow eclipse foundation naming convention.

* Implement liveliness support (#632)

* Mark liveliness API as unstable and disable by default

* Fix typo (#787)

* fix: prevent code duplication during merge

---------

Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: DenisBiryukov91 <[email protected]>
Co-authored-by: Denis Biryukov <[email protected]>
Co-authored-by: Diogo Mendes Matsubara <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants