Optimize performance of text replacer context with autowrap and already formatted document #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unnecessary text replacer contexts by returning the current context when the resulting context would be identical. Signed-off-by: Martin Jobst <[email protected]>
…xt#3119 When calculating the leading chars in a line, the replacer context iterates over all previous contexts if there are no replacements. This change also uses the region of the associated replacer to find the beginning of the current line. Signed-off-by: Martin Jobst <[email protected]>
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the leading chars in a line, the replacer context iterates over all previous contexts if there are no replacements. This PR also uses the region of the associated replacer to find the beginning of the current line.
Furthermore, it avoids unnecessary text replacer contexts by returning the current context when the resulting context would be identical.
Closes #3119