fixed generators for test and example languages #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdietrich
reviewed
Apr 20, 2024
| @@ -72,7 +72,6 @@ private BuilderTestLanguagePackageImpl() | |||
| { | |||
| super(eNS_URI, BuilderTestLanguageFactory.eINSTANCE); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
is these changes cause you dont use emf 2022-03 as tp?
There was a problem hiding this comment.
@cdietrich it can be: I'm always using the latest TP. Do you want me to remove them from the PR?
There was a problem hiding this comment.
this is an "argggggggg" problem. strictly i like to have the variant with the minimal emf version.
so yes. but i can also live with it.
am not sure if we will run into a new emf version where there is a real change
There was a problem hiding this comment.
@cdietrich I've pushed force without the modified Java files
cdietrich
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2998
I also added the small chances after running generators