Replace concatenates Strings by Text-Blocks in CompilerTests #2991
+2,546
−2,410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the readability of Strings defining the test-input and expected output. It avoids the need to explicitly add new-line characters and the need to escape double-quotes.
HannesWell
force-pushed
the
text-blocks_in_compilerTests
branch
from
21af390 to
952f634
Compare
cdietrich
reviewed
Apr 14, 2024
| @@ -20,7 +20,7 @@ | |||
| <attribute name="test" value="true"/> | |||
| </attributes> | |||
| </classpathentry> | |||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11/"/> | |||
There was a problem hiding this comment.
am not sure if i am ok with that just for the test
There was a problem hiding this comment.
This PR aims to the time, when Java-17 is already the required minimum. I assumed this will the case as soon Java-21 is supported? So this is actually a draft.
If you are interested in a PR that bumps the required Java-version for all bundles, I can provide one just for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the readability of Strings defining the test-input and expected output. It avoids the need to explicitly add new-line characters and the need to escape double-quotes.
Currently the tests require only Java-11, but it was said that as part of #2686 Java-17 will be the required minimum.