Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Xtend core performance tests in xtend.performance.tests project #2891

Merged

Conversation

LorenzoBettini
Copy link
Contributor

In xtend.core.tests there are two performance test PerformanceTest and XtendIncrementalBuilderPerformanceTest that are "a bit in the way" when running tests in xtend.core.tests: there's no easy way to exclude them and the launch configurations were meant for the old gradle age, so they don't help anymore.

This PR:

  • move those tests in the xtend.performance.tests project; in that project there are already a few performance tests; those are for the UI, but the above mentioned tests are still related to building so it does not harm to put them in the performance.tests project; I also renamed the name in the POM without the "IDE"
  • update the launch configurations in xtend.core.tests: there are only two of them, one for the Java files and one for the Xtend files.
  • The XtendIncrementalBuilderPerformanceTest used to be in a package that ends with build so its directory it's excluded by the main .gitignore file; it took me a while to understand what was going on. To avoid problems in the future, I renamed its package to building.
  • removed RuntimePerformanceSuite.java since it didn't seem to make sense

@szarnekow
Copy link
Contributor

@LorenzoBettini Would Junit tags be option instead of splitting the project? See org.junit.jupiter.api.Tag

@LorenzoBettini
Copy link
Contributor Author

@szarnekow I think JUnit tags, even with JUnit 4, would work.
It's just that those performance tests looked like they would fit that separate project.
However, I'll investigate JUnit 4 tags. I would keep a few commits of this PR that are more related to clean-up.

@LorenzoBettini
Copy link
Contributor Author

@szarnekow from my understanding JUnit 4 does not provide tags: it provides categories that require proper suite classes. In fact, Eclipse allows for tag selection/exclusion only for JUnit 5.
Thus, for JUnit 4 this would not help.
I'd also avoid switching to JUnit 5 which gave a few headaches in the past.
What do you think?

@szarnekow
Copy link
Contributor

szarnekow commented Jan 8, 2024

Sadness. Ok, I'm fine with a separate test project or with a separate source folder for the performance tests. Whatever you prefer.

@LorenzoBettini
Copy link
Contributor Author

@szarnekow I had also thought about a separate source folder in xtend.core.tests but that would work seamlessly for Java files: the two performance tests are Xtend files, so they are generated into xtend-gen together with the other ones, so the launch configuration could not distinguish them.

@LorenzoBettini LorenzoBettini force-pushed the lb-xtend-performance-tests branch from c7a9c90 to b01d41a Compare January 9, 2024 17:24
@LorenzoBettini
Copy link
Contributor Author

I spotted other performance tests also in xtend.ide.tests; I'd like to move them as well to the project performance.tests

@szarnekow
Copy link
Contributor

I'd like to move them as well

Please do

@LorenzoBettini LorenzoBettini force-pushed the lb-xtend-performance-tests branch from 7e81ddc to 1b3eafa Compare January 10, 2024 09:04
@LorenzoBettini LorenzoBettini force-pushed the lb-xtend-performance-tests branch 2 times, most recently from cd33809 to 28f0dbd Compare January 10, 2024 12:06
@LorenzoBettini LorenzoBettini merged commit 15aa26a into eclipse-xtext:main Jan 10, 2024
6 of 11 checks passed
@LorenzoBettini LorenzoBettini deleted the lb-xtend-performance-tests branch January 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants