-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Xtend core performance tests in xtend.performance.tests project #2891
Moved Xtend core performance tests in xtend.performance.tests project #2891
Conversation
@LorenzoBettini Would Junit tags be option instead of splitting the project? See org.junit.jupiter.api.Tag |
@szarnekow I think JUnit tags, even with JUnit 4, would work. |
@szarnekow from my understanding JUnit 4 does not provide tags: it provides categories that require proper suite classes. In fact, Eclipse allows for tag selection/exclusion only for JUnit 5. |
Sadness. Ok, I'm fine with a separate test project or with a separate source folder for the performance tests. Whatever you prefer. |
@szarnekow I had also thought about a separate source folder in |
otherwise, it gets ignored by .gitignore
which were removed during rebasing
c7a9c90
to
b01d41a
Compare
I spotted other performance tests also in xtend.ide.tests; I'd like to move them as well to the project performance.tests |
Please do |
7e81ddc
to
1b3eafa
Compare
cd33809
to
28f0dbd
Compare
In
xtend.core.tests
there are two performance testPerformanceTest
andXtendIncrementalBuilderPerformanceTest
that are "a bit in the way" when running tests inxtend.core.tests
: there's no easy way to exclude them and the launch configurations were meant for the old gradle age, so they don't help anymore.This PR:
xtend.performance.tests
project; in that project there are already a few performance tests; those are for the UI, but the above mentioned tests are still related to building so it does not harm to put them in the performance.tests project; I also renamed the name in the POM without the "IDE"xtend.core.tests
: there are only two of them, one for the Java files and one for the Xtend files.XtendIncrementalBuilderPerformanceTest
used to be in a package that ends withbuild
so its directory it's excluded by the main.gitignore
file; it took me a while to understand what was going on. To avoid problems in the future, I renamed its package tobuilding
.RuntimePerformanceSuite.java
since it didn't seem to make sense