don't retrieve the ImportManager by reflection #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already assume that the import manager is part of the appendable, which is a TreeAppendable, I think it's better to do the case and expose getImportManager in TreeAppendable than to call that method with two reflective calls. This would also allow clients to provide a custom TreeAppendable; with the reflective call this latter use-case would not be supported
|
@szarnekow I'll split #2888 into separate PRs. |
szarnekow
reviewed
Jan 2, 2024
| @@ -839,12 +839,7 @@ class JvmModelGenerator implements IGenerator { | |||
| } | |||
|
|
|||
| def getImportManager(ITreeAppendable appendable) { | |||
There was a problem hiding this comment.
Should the XbaseCompiler work with TreeAppendable instead of ITreeAppendable on its APIs?
There was a problem hiding this comment.
@szarnekow from what I see and understand, the XbaseCompiler does not need anything more than what the ITreeAppendable interface provides and doesn't seem to make further assumptions.
On the contrary, JvmModelGenerator completely relies on TreeAppendable.
There was a problem hiding this comment.
Meh sadness. We cannot easily change signatures here. Casting seems the best we can do.
szarnekow
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already assume that the import manager is part of the appendable, which is a TreeAppendable, I think it's better to do the case and expose getImportManager in TreeAppendable than to call that method with two reflective calls.
This would also allow clients to provide a custom TreeAppendable; with the reflective call this latter use-case would not be supported