remove xpand based Xtext2Ecore Postprocessor (Xpand removal part 1) #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <[email protected]>
szarnekow
reviewed
Sep 29, 2023
| @@ -141,12 +141,6 @@ public void configureFilterTerminalRulesContribution(Binder binder) { | |||
|
|
|||
| @Deprecated(forRemoval = true) | |||
| public void configureIXtext2EcorePostProcessor(Binder binder) { | |||
There was a problem hiding this comment.
The entire method can be removed, since it is in xtext.xtext.ui
szarnekow
reviewed
Sep 29, 2023
| @@ -122,14 +122,8 @@ public Class<? extends IValueConverterService> bindIValueConverterService() { | |||
| /** | |||
| * @since 2.9 | |||
| */ | |||
| @SuppressWarnings({"removal","deprecation"}) | |||
| @Deprecated | |||
| public void configureIXtext2EcorePostProcessor(Binder binder) { | |||
There was a problem hiding this comment.
i wanted to keep these in a first step and do their removal in a 2nd stage
szarnekow
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2811