#2808: Fix possible NPE in AbstractQuickFixTest #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhotep82
commented
Sep 27, 2023
org.eclipse.xtext.ui.testing/src/org/eclipse/xtext/ui/testing/AbstractQuickfixTest.java
Show resolved
Hide resolved
|
@imhotep82 can you please rebase on the latest main so that the build can work. |
|
Sure thing |
imhotep82
force-pushed
the
2808_hwe
branch
3 times, most recently
from
c0dbb9d to
a57e45a
Compare
szarnekow
reviewed
Sep 27, 2023
org.eclipse.xtext.ui.testing/src/org/eclipse/xtext/ui/testing/AbstractQuickfixTest.java
Outdated
Show resolved
Hide resolved
|
@szarnekow @imhotep82 what is the state of this pr? |
impl is done, waiting for approval |
szarnekow
approved these changes
Sep 29, 2023
My bad, I forgot to correct click sequence. Done. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2808