Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align junit5 in target platforms with eclipse jdts #2228

Merged
merged 6 commits into from
Apr 18, 2023
Merged

align junit5 in target platforms with eclipse jdts #2228

merged 6 commits into from
Apr 18, 2023

Conversation

cdietrich
Copy link
Contributor

align junit5 in target platforms with eclipse jdts

@cdietrich cdietrich added this to the Release_2.31 milestone Apr 17, 2023
@cdietrich cdietrich force-pushed the junit592_in_target_2ndTry branch from 848d980 to daa5322 Compare April 17, 2023 05:43
@LorenzoBettini
Copy link
Contributor

Argh! Now tycho surefire does not see the JUnit 5 tests :'(

@LorenzoBettini
Copy link
Contributor

Maybe this might help https://tycho.eclipseprojects.io/doc/latest/tycho-surefire-plugin/test-mojo.html#providerHint

@cdietrich
Copy link
Contributor Author

cdietrich commented Apr 17, 2023 •
edited
Loading

hmm with the hint
InjectionExtensionTest
still fails at least with r202203

wonder if we should use maven-surefire

@LorenzoBettini
Copy link
Contributor

hmm with the hint InjectionExtensionTest still fails at least with r202203

wonder if we should use maven-surefire

You mean it fails with r202303 right? I see it fail on GitHub Actions.

I don't find InjectionExtensionTest

@cdietrich
Copy link
Contributor Author

/org.eclipse.xtext.testing.junit5.tests/src/org/eclipse/xtext/testing/tests/junit5/InjectionExtensionTest.java
@LorenzoBettini shall i push the config of the hint?

@LorenzoBettini
Copy link
Contributor

yes, please

@cdietrich
use junit5 hint for tycho-surefire
80d747f 
Signed-off-by: Christian Dietrich <[email protected]>
@cdietrich
Copy link
Contributor Author

@LorenzoBettini pushed

@LorenzoBettini
Copy link
Contributor

hmm with the hint InjectionExtensionTest still fails at least with r202203

wonder if we should use maven-surefire

I can reproduce the problem locally... I'll try to switch to maven-surefire

@LorenzoBettini
turned to eclipse-plugin and use maven-surefire
8e8118b 
with tycho-surefire this was failing
org.eclipse.xtext.testing.tests.junit5.InjectionExtensionTest.didUseRegisteredExtension()
@LorenzoBettini
Copy link
Contributor

I think I fixed that in the above commit, but changing to eclipse-plugin instead of eclipse-test-plugin and using maven-surefire instead of tycho-surefire

@cdietrich
Copy link
Contributor Author

cdietrich commented Apr 18, 2023 •
edited
Loading

thx. seems to work now. ok to merge?

@LorenzoBettini
Copy link
Contributor

@cdietrich yes!

@cdietrich cdietrich merged commit 0927719 into main Apr 18, 2023
@cdietrich cdietrich deleted the junit592_in_target_2ndTry branch April 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzoBettini LorenzoBettini LorenzoBettini approved these changes

Assignees
No one assigned
Labels
releng
Projects
None yet
Milestone
Release_2.31
Development

Successfully merging this pull request may close these issues.
2 participants
@cdietrich @LorenzoBettini