[#2174] bump platform maven artifacts to 2023-03 #2187
Conversation
cdietrich
changed the title
|
looks like this needs fix for |
|
unfortunately the log does not seems to have enhough information on this |
|
checking locally the maven plugin tests indeed seem to take the dev bom from sonatype snapshots and not the local build one |
I've already started to work on that (see my corresponding branch). At least the ITs of xtext maven plugin never use snapshots in my branch. I have to adapt the ITs od xtend maven plugin accordingly. |
|
@cdietrich on my branch https://github.com/eclipse/xtext/tree/lb_2158_cleanup-maven-plugins-ITs I've cleaned up the Xtend maven plugin ITs. I now create a new branch merging my branch with yours and see whether together the tests pass. However, if you bump the versions in the BOM, this means that the minimal version of Eclipse deps is 2023-03 while the minimal target platform is 2022-03, is that right? |
|
No In tycho we stay with old version minimal as we did this diverging the last 7 years |
What looks strange to me is that the minimal version in the BOM is higher than the minimum target platform. I seemed to recall it was the other way around or that the minimum target platform corresponded to the minimal version in the BOM. |
|
Minimal target was oxygen until recently although it has no java 11 support but we had |
|
@cdietrich merging the two branches https://github.com/eclipse/xtext/tree/lb_2158_cd_2174 and running Xtend Maven ITs work on my machine. I pushed the branch, let's see if also the CI is happy |
| @@ -63,6 +63,7 @@ public void doTransform(MutableClassDeclaration annotatedClass, @Extension Trans | |||
| if (TracedAccessorsProcessor.TYPES_WITH_GOOD_TO_STRING | |||
| .contains(rt.getType().getSimpleName().toLowerCase())) { | |||
| annotatedClass.addMethod(tracerName(getter), it -> { | |||
| context.setPrimarySourceElement(it, context.getPrimarySourceElement(annotatedClass)); | |||
There was a problem hiding this comment.
Is this intentionally part of this merge request?
|
@cdietrich I see you rebased this branch, so I'm removing the temporary experiment https://github.com/eclipse/xtext/tree/lb_2158_cd_2174 |
cdietrich
force-pushed
the
cd_issue2174
branch
2 times, most recently
from
15c9bfb to
817b5bc
Compare
cdietrich
force-pushed
the
cd_issue2174
branch
2 times, most recently
from
f3f1327 to
6625647
Compare
Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
changed the title
[#2174] bump platform maven artifacts to 2023-03