Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Guava 33 #2876

Closed
cdietrich opened this issue Dec 20, 2023 · 15 comments · Fixed by #2878
Closed

Update to Guava 33 #2876

cdietrich opened this issue Dec 20, 2023 · 15 comments · Fixed by #2878

Comments

@cdietrich
Copy link
Contributor

Orbit 2024-03 now ships with Guava 33
so we need to update

@cdietrich
Copy link
Contributor Author

MWE needs an update too. So will Xpect i guess

@szarnekow
Copy link
Contributor

Might be ok to just raise the upper bound. I’ll have a look.

@cdietrich
Copy link
Contributor Author

i have some untested search and replace available
did it on the train so could not oomph yet

cdietrich added a commit that referenced this issue Dec 20, 2023
@cdietrich
Copy link
Contributor Author

@LorenzoBettini
Copy link
Contributor

@cdietrich I don't see your PR as created...

@cdietrich
Copy link
Contributor Author

i did not create.
i have no idea if it builds is complete etc

LorenzoBettini pushed a commit that referenced this issue Dec 20, 2023
LorenzoBettini pushed a commit to LorenzoBettini/xtext that referenced this issue Dec 20, 2023
@cdietrich
Copy link
Contributor Author

mwe search and replace:
https://github.com/eclipse/mwe/pull/new/cd_guava33

@LorenzoBettini
Copy link
Contributor

There are failures on Xtend and task:

Failures: 
org.eclipse.xtend.ide.tests.compiler.batch.XtendCompilerAntTaskTest.testSrcdirAsAttr
  Run 1: XtendCompilerAntTaskTest.testSrcdirAsAttr:60 Gen folder created
  Run 2: XtendCompilerAntTaskTest.testSrcdirAsAttr:60 Gen folder created
  Run 3: XtendCompilerAntTaskTest.testSrcdirAsAttr:60 Gen folder created
  Run 4: XtendCompilerAntTaskTest.testSrcdirAsAttr:60 Gen folder created

org.eclipse.xtend.ide.tests.compiler.batch.XtendCompilerAntTaskTest.testSrcdirAsNestedPath
  Run 1: XtendCompilerAntTaskTest.testSrcdirAsNestedPath:80 Gen folder created
  Run 2: XtendCompilerAntTaskTest.testSrcdirAsNestedPath:80 Gen folder created
  Run 3: XtendCompilerAntTaskTest.testSrcdirAsNestedPath:80 Gen folder created
  Run 4: XtendCompilerAntTaskTest.testSrcdirAsNestedPath:80 Gen folder created

@cdietrich
Copy link
Contributor Author

i assume there are some wiredo regexes in some ant files

@cdietrich
Copy link
Contributor Author

pushed

@cdietrich
Copy link
Contributor Author

Do we track mwe and bootstrap somewhere else

@szarnekow
Copy link
Contributor

Reopening to make sure the bootstrapping is not forgotten

@szarnekow szarnekow reopened this Dec 22, 2023
@cdietrich
Copy link
Contributor Author

cdietrich commented Dec 30, 2023

published a Xtext 2.34.0.M0 so we can use it in mwe (should be on maven central soon)
https://download.eclipse.org/modeling/tmf/xtext/updates/milestones/2.34.0.M0/

@cdietrich cdietrich added this to the Release_2.34 milestone Dec 30, 2023
@cdietrich
Copy link
Contributor Author

eclipse-mwe/mwe#282
TODO double check i did not miss anything

@cdietrich
Copy link
Contributor Author

done for now. TODO release Xtext M1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants