jdt.compiler.(apt|tool) gone #2134

cdietrich · 2023-01-13T20:48:45Z

jdt.compiler.(apt|tool) gone seems to be removed from jdt
@iloveeclipse @szarnekow do you know if this is intentional?
what is the replacement?

eclipse-jdt/eclipse.jdt.core@457e222
of course it will be painful to make this work with backwards compatibility

The text was updated successfully, but these errors were encountered:

cdietrich · 2023-01-13T20:56:20Z

cc @LorenzoBettini this breaks the changes with eclipse/xtext-maven#146

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich · 2023-01-13T21:00:15Z

the new bundle also seems not to be a fragment anymore

cdietrich · 2023-01-13T21:07:24Z

only explicit usage in maven/gradle (here we still use old version) and wizard,
the question is if there is any eclipse code that relys on the fragments present,
@szarnekow do you know?

LorenzoBettini · 2023-01-13T21:19:44Z

IIRC, It was announced in the cross project dev mailing list as the result of refactoring of ecj. Probably for backward compatibility we could add jdt.feature to the tp? Or maybe those fragments are not needed anymore also for order tp now that we have pinned versions?

iloveeclipse · 2023-01-13T21:28:23Z

https://www.eclipse.org/eclipse/news/4.27/jdt.php#ecj-separated-from-core

cdietrich · 2023-01-14T06:56:08Z

so to be on the safe side we need to add a dependency to
org.eclipse.jdt.core.compiler.batch
where we have a dependency to jdt.core

cdietrich · 2023-01-14T08:05:12Z

find . -name "MANIFEST.MF"| xargs grep org.eclipse.jdt.core | grep -v /build/ | grep -v /target/
./xtext-eclipse/org.eclipse.xtext.ui.shared/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.ui.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.purexbase.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.xbase.ui.testing/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.xtext.ui.examples/projects/fowlerdsl/org.eclipse.xtext.example.fowlerdsl.ui.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.xtext.ui.examples/projects/fowlerdsl/org.eclipse.xtext.example.fowlerdsl.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core,
./xtext-eclipse/org.eclipse.xtext.xtext.ui.examples/projects/domainmodel/org.eclipse.xtext.example.domainmodel.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.xtext.ui.examples/projects/domainmodel/org.eclipse.xtext.example.domainmodel.ui.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.xtext.ui.examples/projects/homeautomation/org.eclipse.xtext.example.homeautomation.ui.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.xbase.ui.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.ui.testing/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.common.types.shared/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.xbase.junit/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.xtext.ui.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.purexbase.eclipse.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.m2e/META-INF/MANIFEST.MF: org.eclipse.jdt.core;resolution:=optional
./xtext-eclipse/org.eclipse.xtext.xbase.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.xbase.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core.manipulation;bundle-version="1.16.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.common.types.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.common.types.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core.manipulation;bundle-version="1.16.0",
./xtext-eclipse/org.eclipse.xtext.builder.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional,
./xtext-eclipse/org.eclipse.xtext.builder/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.xtext.ui/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-eclipse/org.eclipse.xtext.junit4/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-eclipse/org.eclipse.xtext.common.types.eclipse.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-xtend/org.eclipse.xtend.ide/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-xtend/org.eclipse.xtend.ide/META-INF/MANIFEST.MF: org.eclipse.jdt.core.manipulation;bundle-version="1.16.0";resolution:=optional,
./xtext-xtend/org.eclipse.xtend.ide.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-xtend/org.eclipse.xtend.ide.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core.manipulation;bundle-version="1.16.0",
./xtext-xtend/org.eclipse.xtend.core/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional;x-installation:=greedy,
./xtext-xtend/org.eclipse.xtend.standalone/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";visibility:=reexport,
./xtext-xtend/org.eclipse.xtend.core.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-xtend/org.eclipse.xtend.examples/projects/xtend-annotation-examples/META-INF/MANIFEST.MF: org.eclipse.jdt.core,
./xtext-xtend/org.eclipse.xtend.performance.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-extras/org.eclipse.xtext.xbase.testing/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";visibility:=reexport,
./xtext-extras/org.eclipse.xtext.common.types.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-extras/org.eclipse.xtext.java/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-extras/org.eclipse.xtext.builder.standalone/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional,
./xtext-extras/org.eclipse.xtext.generator/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional
./xtext-extras/org.eclipse.xtext.purexbase.tests/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0",
./xtext-core/org.eclipse.xtext.xtext.generator/META-INF/MANIFEST.MF: org.eclipse.jdt.core;bundle-version="3.29.0";resolution:=optional

cdietrich · 2023-01-14T08:16:00Z

i checked, jdt.compiler.core has a dependency to jdt.compiler.batch
thus is assume we can simply remove the tool and apt stuff and would be fine

cdietrich · 2023-01-14T08:17:46Z

@LorenzoBettini could you try that with your usecase for eclipse/xtext-maven#146

iloveeclipse · 2023-01-14T08:20:37Z

i checked, jdt.compiler.core has a dependency to jdt.compiler.batch thus is assume we can simply remove the tool and apt stuff and would be fine

Have you actually read the notes?

All of ECJ packages are re-exported by org.eclipse.jdt.core, therefore from OSGI point of view, all 3rd party code that used some compiler related API from org.eclipse.jdt.core doesn't require any change.

So if some target definition, launch configuration or build file referenced the two fragments, these references can and should be removed now.

…(tool|apt) Signed-off-by: Christian Dietrich <[email protected]>

cdietrich · 2023-01-14T08:23:41Z

i was confused by the second "problem" that point do "ant" like environments

Signed-off-by: Christian Dietrich <[email protected]>

iloveeclipse · 2023-01-14T08:28:46Z

Do you have non OSGI based use case where Xtext used in a plain Java application (means, no dependencies resolving via manifests through OSGI container)? In that case you need to add batch compiler bundle to the classpath.

cdietrich · 2023-01-14T08:29:57Z

only if users do not use maven or gradle or tycho to provide the classpath
like calling xtend compiler from ant as your company does @iloveeclipse

cdietrich · 2023-01-14T08:31:44Z

@iloveeclipse @merks can you tell / do you know if there are is a maven snapshot repo available for jdt and platform meanwhile?

iloveeclipse · 2023-01-14T08:33:55Z

We do use xtext from OSGI context, and that's is a different problem (too much of context) :)
There was only one place we had where we used jdt core for Java parsing from ant - and that was the only place where extra batch compiler needed now.

merks · 2023-01-14T08:35:23Z

This job should be doing that

https://ci.eclipse.org/releng/view/Publish%20to%20Maven/

With results published here:

https://repo.eclipse.org/content/repositories/eclipse-snapshots/

This JDT stuff indeed looks very new:

https://repo.eclipse.org/content/repositories/eclipse-snapshots/org/eclipse/jdt/

iloveeclipse · 2023-01-14T08:40:34Z

This JDT stuff indeed looks very new:

Note, it still has ecj and doesn't have compiler batch. Also note, ecj is the compiler batch bundle.

merks · 2023-01-14T10:14:46Z

What is there is as expected and is correct...

There is this mapping rule:

That produces the expected ecj artifact name:

That artifact has the expected symbolic name:

And eventually, when release, it will end up here as before:

https://repo1.maven.org/maven2/org/eclipse/jdt/ecj/

So what we see in this snapshot repository is what we will see after it's published to Maven central...

cdietrich · 2023-01-14T10:37:01Z

=> we should do a branch where we update to latest platform
and also adds

<dependency>
<groupId>org.eclipse.jdt</groupId>
<artifactId>ecj</artifactId>
<version>3.33.0-SNAPSHOT</version>
</dependency>

to the dev bom.

remove all maven/gradle refs to compiler tool+apt

Signed-off-by: Christian Dietrich <[email protected]>

[eclipse-xtext/xtext#2134] remove dependency to obsolte jdt.compiler.(tool|apt)

[eclipse-xtext/xtext#2134] replace compiler.tool+apt with batch

cdietrich · 2023-01-17T11:48:59Z

testing blocked by eclipse-platform/eclipse.platform.releng.aggregator#811

cdietrich · 2023-01-23T12:50:33Z

have to wait for testing until the deploy issue consuming from gradle is resolved or 4.27 is released

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added this to the Release_2.30 milestone Jan 13, 2023

cdietrich added the releng label Jan 13, 2023

cdietrich added a commit to xtext/xtext-reference-projects that referenced this issue Jan 13, 2023

[eclipse-xtext/xtext#2134] replace compiler.tool+apt with batch

174cde8

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich mentioned this issue Jan 13, 2023

[eclipse/xtext#2134] replace compiler.tool+apt with batch xtext/xtext-reference-projects#320

Merged

cdietrich added a commit to eclipse/xtext-core that referenced this issue Jan 14, 2023

[eclipse-xtext/xtext#2134] remove dependency to obsolte jdt.compiler.…

13ac379

…(tool|apt) Signed-off-by: Christian Dietrich <[email protected]>

cdietrich mentioned this issue Jan 14, 2023

[eclipse/xtext#2134] remove dependency to obsolte jdt.compiler.(tool|apt) eclipse/xtext-core#2053

Merged

cdietrich added a commit to xtext/xtext-reference-projects that referenced this issue Jan 14, 2023

[eclipse-xtext/xtext#2134] replace compiler.tool+apt with batch

aac2257

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-lib that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

0c9d332

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-core that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

f947644

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-core that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

d49eac9

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-extras that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

39d010e

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-xtend that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

e6d977f

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-web that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

9b3d4a8

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-extras that referenced this issue Jan 16, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

865d3b6

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-core that referenced this issue Jan 17, 2023

Merge pull request #2053 from eclipse/cd_xtext_issue2134

09d7556

[eclipse-xtext/xtext#2134] remove dependency to obsolte jdt.compiler.(tool|apt)

cdietrich added a commit to xtext/xtext-reference-projects that referenced this issue Jan 17, 2023

Merge pull request #320 from itemis/cd_xtext_issue2134

fe81825

[eclipse-xtext/xtext#2134] replace compiler.tool+apt with batch

cdietrich self-assigned this Jan 18, 2023

cdietrich mentioned this issue Jan 26, 2023

Move to Maven/Tycho for projects and build infrastructure eclipse/xtext-extras#859

Closed

cdietrich modified the milestones: Release_2.30, Release_2.31 Feb 17, 2023

cdietrich added a commit to eclipse/xtext-lib that referenced this issue Mar 14, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

4cd2f96

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-core that referenced this issue Mar 14, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

74346f9

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-extras that referenced this issue Mar 14, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

bc059de

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-xtend that referenced this issue Mar 14, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

b1ee796

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-web that referenced this issue Mar 14, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

de9930c

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-lib that referenced this issue Mar 15, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

d641f38

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-lib that referenced this issue Mar 15, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

e8a4527

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich added a commit to eclipse/xtext-lib that referenced this issue Mar 15, 2023

[eclipse-xtext/xtext#2134] test with eclipse 4.27 snapshot

ed57cce

Signed-off-by: Christian Dietrich <[email protected]>

cdietrich mentioned this issue Apr 3, 2023

Update to 2023-03 platform in maven/bom #2174

Closed

cdietrich modified the milestones: Release_2.31, Release_2.32 May 22, 2023

cdietrich closed this as completed Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jdt.compiler.(apt|tool) gone #2134

jdt.compiler.(apt|tool) gone #2134

cdietrich commented Jan 13, 2023 •

edited

Loading

cdietrich commented Jan 13, 2023

cdietrich commented Jan 13, 2023

cdietrich commented Jan 13, 2023 •

edited

Loading

LorenzoBettini commented Jan 13, 2023

iloveeclipse commented Jan 13, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

iloveeclipse commented Jan 14, 2023

cdietrich commented Jan 14, 2023 •

edited

Loading

iloveeclipse commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

iloveeclipse commented Jan 14, 2023

merks commented Jan 14, 2023

iloveeclipse commented Jan 14, 2023

merks commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 17, 2023

cdietrich commented Jan 23, 2023

jdt.compiler.(apt|tool) gone #2134

jdt.compiler.(apt|tool) gone #2134

Comments

cdietrich commented Jan 13, 2023 • edited Loading

cdietrich commented Jan 13, 2023

cdietrich commented Jan 13, 2023

cdietrich commented Jan 13, 2023 • edited Loading

LorenzoBettini commented Jan 13, 2023

iloveeclipse commented Jan 13, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

iloveeclipse commented Jan 14, 2023

cdietrich commented Jan 14, 2023 • edited Loading

iloveeclipse commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 14, 2023

iloveeclipse commented Jan 14, 2023

merks commented Jan 14, 2023

iloveeclipse commented Jan 14, 2023

merks commented Jan 14, 2023

cdietrich commented Jan 14, 2023

cdietrich commented Jan 17, 2023

cdietrich commented Jan 23, 2023

cdietrich commented Jan 13, 2023 •

edited

Loading

cdietrich commented Jan 13, 2023 •

edited

Loading

cdietrich commented Jan 14, 2023 •

edited

Loading